slince / shopify-api-php

:rocket: Shopify API Client for PHP
MIT License
128 stars 47 forks source link

Adding discount price to shipping line #79

Closed danielcuervo closed 3 years ago

danielcuervo commented 4 years ago

Adding a discount price field in the shipping line jms serializer mapping

codecov[bot] commented 4 years ago

Codecov Report

Merging #79 into master will decrease coverage by 0.60%. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #79      +/-   ##
============================================
- Coverage     88.27%   87.66%   -0.61%     
  Complexity     1386     1386              
============================================
  Files           100      100              
  Lines          3402     3388      -14     
============================================
- Hits           3003     2970      -33     
- Misses          399      418      +19     
Impacted Files Coverage Δ Complexity Δ
...c/Manager/InventoryLevel/InventoryLevelManager.php 72.72% <0.00%> (-18.58%) 8.00% <0.00%> (ø%)
src/Manager/Asset/AssetManager.php 84.00% <0.00%> (-12.30%) 8.00% <0.00%> (ø%)
src/Common/Manager/GeneralCurdable.php 88.23% <0.00%> (-11.77%) 6.00% <0.00%> (ø%)
...cationCharge/RecurringApplicationChargeManager.php 70.00% <0.00%> (-10.96%) 8.00% <0.00%> (ø%)
src/Common/Manager/NestCrudable.php 89.65% <0.00%> (-10.35%) 8.00% <0.00%> (ø%)
src/Manager/ProductVariant/VariantManager.php 77.77% <0.00%> (-8.43%) 10.00% <0.00%> (ø%)
src/Client.php 87.34% <0.00%> (-6.78%) 31.00% <0.00%> (ø%)
src/Manager/CustomerAddress/AddressManager.php 44.44% <0.00%> (+2.33%) 7.00% <0.00%> (ø%)
src/Manager/Customer/CustomerManager.php 47.36% <0.00%> (+2.36%) 7.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update da9cb0d...e122707. Read the comment docs.

slince commented 3 years ago

2.x version is coming to an end; can you send pr to 3.x branch?