search

slinga-homebrew / Save-Game-Copier

Copy Sega Saturn save game files
GNU General Public License v3.0
48 stars 8 forks source link

Better error handling for corrupt save files #17

Closed RevQuixo closed 3 years ago

RevQuixo commented 3 years ago

I had on my official save cartridge a couple of 1 memory unit junk files..not sure where they came from. The built-in bios level saturn memory manager had no issue reading the entire contents of the cart, but the Save Game Copier throws an error for listing files until I went in and deleted these junk files. Not sure if there is a more graceful way of listing or identifying corrupt files in a memory source without throwing an error.

slinga-homebrew commented 3 years ago

I'm using Jo Engine which I believe uses the BUP library under the hood. Not sure why there would be a difference. Do you have an example filename so I can try to repro?

RevQuixo commented 3 years ago

I don't currently as I deleted the offending files in order to get the copier to ultimately read the directory, I'll keep an eye out for users who have issues though while using MODE. The problem though is there is no way to share them as it is a chicken/egg issue. For whatever reason though the Saturn will happily display corrupt saves but Copier won't. The only thing I can think of is somehow to loosen whatever validity check is going into the current methodology in Copier.

slinga-homebrew commented 3 years ago

I think release 3.6.1 should handle this issue. If not please re-open.