search

slinga-homebrew / Save-Game-Copier

Copy Sega Saturn save game files
GNU General Public License v3.0
48 stars 8 forks source link

Cartridge Memory will not display more than 32 items #19

Closed RevQuixo closed 3 years ago

RevQuixo commented 3 years ago

As reported on TerraOnion discord a user had 60+ items and only the first 32 will display. He needed to save those off, delete the first 32 and then the rest would display.

slinga-homebrew commented 3 years ago

MAX_SAVES is set to 255 so I'm not sure where I messed up. Will have time this weekend to dig into it.

slinga-homebrew commented 3 years ago

I can't repro this. I had a CD with 60+ saves and I didn't have an issue with the listing code. I can try testing directly from the cartridge when I get some time.

RevQuixo commented 3 years ago

I'll ty to get some more eyeballs on this on my end.

RevQuixo commented 3 years ago

vampire savior, winter heat, and x-men vs sf are missing from the cartridge memory view in SGC (and possibly more)

RevQuixo commented 3 years ago

I have 66 items on my cartridge and it is only showing 32

slinga-homebrew commented 3 years ago

Lol just like the other thread I'm stumped. I buildta debug version with extra logging to help diagnose: https://github.com/slinga-homebrew/Save-Game-Copier/releases/tag/3.2.2.1.

Basically I print out the count of saves multiple times. Can you tell me those numbers?

slinga-homebrew commented 3 years ago

Ok looks like I was able to repro the issue. There's a cap to 32 files for some reason. I'll look through Jo Source.

slinga-homebrew commented 3 years ago

In Jo Engine's backup.h:

define JO_BACKUP_MAX_FILE (32)

What do you think is a reasonable amount? 128?

RevQuixo commented 3 years ago

Is 255 to match the max saves too much? I had 66 saves on my card and still 4,000 blocks free, So I can see going over 128 easily.

slinga-homebrew commented 3 years ago

This appears fixed with the newest Jo Engine. I'll make a new release tomorrow.

slinga-homebrew commented 3 years ago

https://github.com/slinga-homebrew/Save-Game-Copier/releases/tag/3.2.3

Let me know if you have any issues.