slint-ui / slint

Slint is a declarative GUI toolkit to build native user interfaces for Rust, C++, or JavaScript apps.
https://slint.dev
Other
17.55k stars 601 forks source link

Documentation for various structs is missing #4153

Closed tronical closed 11 months ago

tronical commented 11 months ago

This affects the documentation of the following types in the Node.js API:

In 1.3.0 the fields are visible and documented. Starting with 1.3.1 the documentation is empty and there are no more documented fields.

This is a regression.

FloVanGH commented 11 months ago

This is what is changes related to this four types from 1.3.0

export {
    Diagnostic,
    DiagnosticLevel,
    RgbaColor,
    Brush
} from "./rust-module";

to 1.3.1

const {
    Diagnostic,
    DiagnosticLevel,
    RgbaColor,
    Brush
} = napi;

export {
    Diagnostic,
    DiagnosticLevel,
    RgbaColor,
    Brush
};

This could cause the trouble with the documentation. It was change in this commit https://github.com/slint-ui/slint/commit/84fd6dc08cb71b13d5b8f26a2a83405177e5c8b6

tronical commented 11 months ago

Yes indeed, I introduced this regression.