search

slint-ui / slint

Slint is a declarative GUI toolkit to build native user interfaces for Rust, C++, or JavaScript apps.
https://slint.dev
Other
17.55k stars 601 forks source link

i-slint-backend-android-activity: build.rs use wrong way to call d8 on windows #4524

Closed Jhonfunk closed 9 months ago

Jhonfunk commented 9 months ago

https://github.com/slint-ui/slint/blob/1e58930d7eeaf53b7622994a80bf12a838d1e294/internal/backends/android-activity/build.rs#L62

On windows there is no d8.exe only d8.bat. and the parameters are passed differently. sdfs

ogoffart commented 9 months ago

Thanks for filling a bug.

I'm not familiar with Android development on windows. Would you be able to provide a PR that fixes the issue?

ogoffart commented 9 months ago

Actually, @tronical already made a PR https://github.com/slint-ui/slint/pull/4530