search

slipcor / TreeAssist

https://www.spigotmc.org/resources/treeassist.67436/
GNU General Public License v3.0
34 stars 19 forks source link

[1.16.1] New netherite axe missing in default config #50

Closed henrik9999 closed 4 years ago

henrik9999 commented 4 years ago

Title explains everything for now I just added the tool myself in the config.

slipcor commented 4 years ago

Oh yeah, simple oversight that will be fixed in no time. Configs will be updated automatically, if ppl did not add them already, like you :)

Thanks for reporting this :)

henrik9999 commented 4 years ago

Oh yeah btw while going through the code I saw this https://github.com/slipcor/TreeAssist/blob/master/src/main/java/net/slipcor/treeassist/utils/ToolUtils.java#L33 Does netherite have to be added there? Or is the default value alright?

slipcor commented 4 years ago

I strongly assume it has to be added, the default value is for "wrong tool" and probably very high. Thank you for pointing this out, I will look up the proper breaking time for netherite axe and wood :)

henrik9999 commented 4 years ago

It should be a little bit faster than diamond but I don't know the exact value currently

slipcor commented 4 years ago

Back when I accepted this addition from someone I probably did not even care to check the wiki.

Anyway, the method has been updated with the current items and now also calculates the cooldown for leaves and stripped logs, should you allow stripped trees to be part of this :D

The function will now return an accurate time it WOULD have taken to fell all of the blocks in the tree based on all valid minecraft tools. Hoes, shears and swords for leaves, axes for logs :)

This will be committed now :)

henrik9999 commented 4 years ago

Cool :) then I will be closing this now