slipcor / TreeAssist

https://www.spigotmc.org/resources/treeassist.67436/
GNU General Public License v3.0
34 stars 19 forks source link

Breaking a single log of a tree makes it unable to be chopped #86

Closed TBG-FR closed 2 years ago

TBG-FR commented 2 years ago

Another little things I've found 👀

Reproduction

Comments

slipcor commented 2 years ago

Yeah I am sorry to say that once you break a log of a valid tree, but for some reason you do not trigger the auto-destruct (like the sneaking setting), then the rest of the tree becomes an invalid tree :/

I am hesitant with a possible fix for this, like, remembering the "remaining parts of trees that have been cut" --- but this can be easily abused by someone running through a forest and breaking one log of each tree, and your server would have to remember all the remaining trees, for the possibility of some player finally hitting another block and triggering the auto destruct.

I am open to the idea of testing it though... to see the impact it might have on RAM usage or the like 🙈

slipcor commented 2 years ago

To counter this for now, you can set "Forced Removal: false" to true and then the plugin forcibly breaks remnants of the tree (but does not drop logs :) )

TBG-FR commented 2 years ago

Thanks for the explanation, alternatives and thoughts on that !

IMO it would be easier to find a way to make it stay a valid tree, that would avoid that kind of abuse and/or performance impact 😅 But I believe that it's not that easy ahah