search

slipmatio / control-knob

Rotary control knob for Vue 3 that behaves like audio app controls.
MIT License
11 stars 2 forks source link

Feat: prevent page scrolling on mouse wheel #10

Closed suterma closed 2 years ago

suterma commented 2 years ago

Finally worked through it.

Please note: I tried to add some cypress tests (a first for me, and I kind of liked it), but I did not manage to have "real" keypresses or mouse wheel events, that actually break things as expected. So, in the current form, they are quite useless. You might want to fix them, if possible, or just remove them.

Best Regards, Marcel

Fixes #8

Uninen commented 2 years ago

Thank You for your work, this looks much better 👍

Don't worry about the tests. I didn't have time to write proper ones for the current implementation so it's hard to add more on top. In addition, I'm planning to convert all browser-tests to using Playwright (for resons) so I need to rework everything in any case.

suterma commented 2 years ago

Incorporated the requested changes. Thanks for the prettier formatting rules, this now works much better for me.