search

slipset / deps-deploy

deploy your stuff
Eclipse Public License 1.0
148 stars 31 forks source link

Remove the need to specify jar file #5

Closed jeluard closed 3 years ago

jeluard commented 5 years ago

Leverage the data read from the pom file to locate the Jar file. Current solution is a bit fragile as it requires specifying the same info (like version) twice.

slipset commented 5 years ago

I believe the commits leading up to and including https://github.com/slipset/deps-deploy/commit/80897f395bee7a46cf7045e29789e65ce232870a solves this?

jeluard commented 5 years ago

So I don't have to specify the "path/to/my.jar" argument? How would that work?

slipset commented 5 years ago

No, you still have to specify the path to the jar, because I can’t see where that info is stored in the pom.xml?

Is there anything I’ve misunderstood/not seen?

jeluard commented 5 years ago

I can see build/directory, and packaging, looks like the rest is already known?

seancorfield commented 4 years ago

I don't think you can rely on those parts of pom.xml to find the specific, named JAR file that should be deployed. You certainly can't rely on them in the general case -- and I'm not convinced there is a sane default for most POM files: look at what clojure -Spom generates and the build/directory is src (not helpful) and there's no "packaging" information there.

In a Leiningen world, sure, lein pom jar produces what you suggest but lein already knows how to deploy so deps-deploy isn't relevant.