search

slipset / deps-deploy

deploy your stuff
Eclipse Public License 1.0
148 stars 31 forks source link

README suggest deploying using the classpath #54

Open mortenschioler opened 1 year ago

mortenschioler commented 1 year ago

In the README, it is suggested that the correct use of the dependency is 

{:deploy {:extra-deps {slipset/deps-deploy {:mvn/version "RELEASE"}}
          :exec-fn deps-deploy.deps-deploy/deploy
          :exec-args {:installer :remote
                      :sign-releases? true
                      :artifact "deps-deploy.jar"}}}

But since the project classpath is not necessary for deploying an artifact that's already been built, I would argue that a better usage with improved performance and less possibility for dependency conflict would be achieved by using :replace-deps (which is the same as :deps in the context of aliases but is more precise): 

{:deploy {:replace-deps {slipset/deps-deploy {:mvn/version "RELEASE"}}
          :exec-fn deps-deploy.deps-deploy/deploy
          :exec-args {:installer :remote
                      :sign-releases? true
                      :artifact "deps-deploy.jar"}}}