Closed konstan closed 7 years ago
The code review has been made. I'm in the processing of testing.
Regarding the changed files, only the TestCloudWrapper.py had a pylint score below 6 (3.62).
Congratulations to OrchestratorDeploymentExecutor.py, with a 9.42 score!
Regarding ratings with pylint. There is our custom https://github.com/slipstream/SlipStreamClient/blob/master/client/pylint.config running with which gives 6.11 to TestCloudWrapper.py ;)
$ pylint --rcfile pylint.config ./src/test/python/TestCloudWrapper.py | grep 'Your code has been rated'
Your code has been rated at 6.11/10 (previous run: 6.11/10, +0.00)
$
The issue with no bootstrap delivered to VM during the contextualisation on eo-cesnet-cz1
on validation instance was due to too old reference configuration. It had an old setting for contextualisation on eo-cesnet-cz1
-- one-context
. After setting it to cloud-init
everything works.
This branch was fully based on
issue_#14-requests
branch with RP #339. There is no need to merge #339, just check what was done there as the change betweenhttplib2
andrequests
.Connected to #338