Enhance logging and behavior of job engine

0xbase12 commented 6 years ago

Connected to #16 Connected to #19

schaubl commented 6 years ago

@0xbase12 Why not using threading.current_thread() and then Thread.name.

schaubl commented 6 years ago

The usage of ZooKeeper in the Job object create some (potential) code weakness:

The code that manage the state with ZooKeeper is not centralized anymore (divided between the Executor class and the Job class.
The Job class (which was a "helper" to access and manipulate a CIMI job) cannot be used independently of ZooKeeper anymore and now it's not independant anymore of the job dispatcher (ZK) so it will complexify for example testing and especially unit testing.

However the current state of the code within this PR is seen as a required intermediate state to better understand and debug corner cases that can happens with the "complex" relation between ZK and CIMI jobs.

This will have to be refactored on the next iteration so that the ZooKeeper related code in the Job class will be merged back into the Executor class.

slipstream / SlipStreamJobEngine

Enhance logging and behavior of job engine #37