search

slipstream / SlipStreamJobEngine

SlipStream distributed job engine
Apache License 2.0
0 stars 0 forks source link

Copy the price:currency one level up from serviceOffer #55

Closed elegoff closed 6 years ago

elegoff commented 6 years ago

Connected to https://github.com/slipstream/SlipStreamServer/issues/1636

cjdcordeiro commented 6 years ago

@elegoff are you sure this is enough? The VM collector job is not populating that attribute into the VM resource, so I think just changing the schema is not enough (https://github.com/slipstream/SlipStreamJobEngine/blob/master/job/src/slipstream/job/actions/virtual_machines_collect.py#L275)

elegoff commented 6 years ago

I expect it should be enough since the collector use a CIMI add (https://github.com/slipstream/SlipStreamJobEngine/blob/master/job/src/slipstream/job/actions/virtual_machines_collect.py#L158) and its implementation ensures to add a currency attribute to the VM resource whenever a price:currency attribute is present in the serviceOffer (https://github.com/slipstream/SlipStreamServer/blob/master/cimi-resources/src/com/sixsq/slipstream/ssclj/resources/virtual_machine.clj#L78). NB : This pattern is also used for the storage-bucket (https://github.com/slipstream/SlipStreamServer/blob/master/cimi-resources/src/com/sixsq/slipstream/ssclj/resources/storage_bucket.clj#L78)