chore: technical debt - Githubissues

slipx06 / sunsynk-power-flow-card

⚡A customizable Home Assistant card to emulate the Sunsynk System flow that's displayed on the Inverter screen.

MIT License

186 stars 53 forks source link

chore: technical debt #303

Closed Pho3niX90 closed 6 months ago

Pho3niX90 commented 6 months ago

Major refactor. Move all consts related to inverters, to their own individual managed classes. This improves the overall readability, as well as making it easier to add new ones.
split out cards to their own classes, for better readability, maintenance, and to reduce IDE memory footprint.

Description

Motivation and Context

Reduces overall code debt
Improves ease of adding new support for inverters.
Improves IDE memory overhead
This will also make it easier to componentize the 2 cards into smaller components going forward, where there is an overlap of HTML logic. Reduction of similar variable names, and refactoring all variable names into a singular coding standard and naming convention.

How has this been tested

Type of change

Please delete options that are not relevant.

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Pho3niX90 commented 6 months ago

fixes: #226 & #91

slipx06 commented 6 months ago

Thanks for all the improvements