sliteteam / github-action-git-crypt-unlock

Github Action to unlock git-crypt secrets
MIT License
47 stars 23 forks source link

Add support for running git-crypt in a path other than GITHUB_WORKSPACE #8

Closed adevine closed 8 months ago

adevine commented 4 years ago

Setting a RUN_DIR env var allows executing this from a directory other than GITHUB_WORKSPACE. This may be necessary if you have a build that pulls down multiple repos.

ArnaudRinquin commented 4 years ago

@adevine Thanks for your contribution but I think this might be unecessary: what about using the working-directory: instruction in workflows? It's a shame it's not well explained in GitHub Actions docs.

- name: Install dependencies
  working-directory: docs
  run: |
    npm install
jtomaszewski commented 3 years ago

working-directory does not work, just tried it:

image

BTW. Shouldn't we be using something like this?

with:
  path: docs

just like for example you'd pass path to actions/checkout@v2 .

edbighead commented 3 years ago

If this can be merged, it might solve the issue when the action runs on custom runners and the /home/gha-actions-runner/_work/myrepo/myrepo/.git/git-crypt/keys/default is being owned by root:rootresulting in '/home/gha-actions-runner/_work/myrepo/myrepo/.git/git-crypt/keys/default': Permission denied during checkout and cleanup steps. @ArnaudRinquin you think it can be merged?

folgarr commented 3 years ago

@ArnaudRinquin can this be merged? this would also help us quite a bit - thanks!

vglafirov commented 2 years ago

There is no activity on this repo for 2 years. I am giving up :(

eleni-salamani commented 1 year ago

+1

ArnaudRinquin commented 8 months ago

Sorry folks, didn't noticed PR. Let's merge cc @eleni-salamani @vglafirov @folgarr @adevine