search

sliverfishes / silverfish

Silverfish - WotOG update
28 stars 30 forks source link

Support Hearthbuddy 0.3.1267.298 #33

Closed x014 closed 8 years ago

x014 commented 8 years ago

Support Hearthbuddy 0.3.1267.298

sliverfishes commented 8 years ago

Hmm, I guess I can't use c# 6 sugar with HB. I have some nitpicking with the PR though and because I'm in a bit of a rush with kara I will give you a few hours to make the changes if you want to before I do it myself.

Please remove the 7zip and version # change, I will package it myself.

x014 commented 8 years ago

Revert the 7zip and version # change yet

sliverfishes commented 8 years ago

What happened to all the null check changes? Is c# 6 null propagation with ?. okay or not?

sliverfishes commented 8 years ago

Also whenever it is ready please create a new branch, cherry-pick the commits that matter from your master to the new branch, and then PR the new branch.

x014 commented 8 years ago

in Hearthbuddy, c# 6 can't be identified. so report errors.

x014 commented 8 years ago

sorry, please close this pull request. i create a new branch, then pull new request.