sll552 / DiscordBee

MusicBee plugin that updates your Discord status with the currently playing track
Apache License 2.0
421 stars 31 forks source link

Cannot Change (_ of _) Field #27

Closed Gimzie closed 4 years ago

Gimzie commented 4 years ago

DiscordBee seems to ignore anything I put into the ( of ) field in the configuration menu, leading it to always show "(1 of 1)" by the bottom field.

To Reproduce

  1. Go into the configuration menu for DiscordBee.
  2. Change the two fields enclosed in parentheses to anything else.
  3. Observe as the field does not change on Discord.

    • MusicBee Version: 3.3.7310
    • Plugin Version: v1.3.0

I think this is related to the library update, because DiscordBee v1.2.1 does not have this issue and I am currently using it without any problems.

sll552 commented 4 years ago

Thanks for reporting,

indeed it seems like the new library is handling the case of a party size of 0 (this happens when you set something that is not a number for one of the (x of x) fileds) differently than it was before. I will try to fix this asap

sll552 commented 4 years ago

Could you please try the following version, it should fix your problem: https://ci.appveyor.com/api/buildjobs/8h9l9e88j4c27ogh/artifacts/DiscordBee-Release-fix_party_size-68.zip

Gimzie commented 4 years ago

Sorry for the late response, but I tried your build and it seems to work fine! Thank you for the quick response, I'll go ahead and close this now.