search

sll552 / DiscordBee

MusicBee plugin that updates your Discord status with the currently playing track
Apache License 2.0
419 stars 30 forks source link

Album cover and "listening" instead of playing #3

Closed llkiriell closed 2 years ago

llkiriell commented 6 years ago

Hi, great job with the plugin, thanks. Will the album cover be implemented? and "Listening" instead of "Playing"? In the JS API there is the .setPresence method that has the attribute "game.type" where you can change "playing" to "listening". Is there an identical method in the API that has been used in this plugin? game type

sll552 commented 6 years ago

I am using the DiscordRichPresence which is different to the "normal" Presence that is described in the JS library you linked. The available fields for RichPresence are described here and there is also a picture that shows which value is which in the Discord UI. Unfortunately it's currently not possible to set the type to something else than "Playing" when using RichPresence. There is an issue that tracks this at Discord https://github.com/discordapp/discord-rpc/issues/71

For Album cover it's the same, it is currently not supported but there is also an issue (https://github.com/discordapp/discord-rpc/issues/70) for this feature at Discord and I will implement that as soon as it is supported.

I will keep this issue open to track this request.

ghost commented 6 years ago

What if you tried to use Last.fm covers for the covers instead? It'd probably be a whole different pickle alone and it'd be easier to wait for the issue on RPC to be addressed, but it's something.

sll552 commented 6 years ago

I don't know what you mean with using Last.fm covers.

Currently it is only possible to display pictures that are preuploaded (by me) to the Discord developer dashboard. There is also a limit of 150 pictures for the app. This is documented here.

ghost commented 6 years ago

Understood. I had no clue how images worked, so I was just taking a guess.

vi11ain commented 6 years ago

@JBoughter Same, looked through the source code, trying to figure out how to implement a changing artwork but could not figure out how the hell the text "logo" or "play" etc are responsible to changing image.

Thanks for keeping us informed op (:

sll552 commented 6 years ago

Well I don't think this is a use case I want to support. But nonetheless you are free to install Visual Studio Community (it's free), clone/fork this repo, change the AppID in the code and press the compile button. It should even work out of the box to just press the "Run" button in VS and it should install your version of the Plugin if MusicBee is installed in the default Place. The only downside would be that you would have to merge new features manually and build again.

lilbud commented 6 years ago

Instead of having to upload images to the servers. Could the artwork be read directly from the tag in the music file? Or maybe show art in the music file folder named something like cover.jpg?

I know next to nothing about code, so I could be talking nonsense.

wopian commented 6 years ago

@lilbud no. The images have to be explicitly uploaded by the application owner on Discord. It can't display arbitrary images. 😢

plskillmeirl21 commented 6 years ago

is there any way to modify the "MusicBee" above the artist name and title?

sll552 commented 6 years ago

@plskillmeirl21 unfortunately there is currently no way to change this. This is the name of the App that is registered to Discord, basically it's the name of the "game" you are playing.

I will now lock the conversation as there are only the same questions over and over again. I will update this issue when Discord decides to implement the needed feature.