sll552 / DiscordBee

MusicBee plugin that updates your Discord status with the currently playing track
Apache License 2.0
421 stars 31 forks source link

Virtual tags past 16 do not show in version 1.4.1 #66

Closed Rings4 closed 3 years ago

Rings4 commented 3 years ago

Describe the bug Virtual tags past 16 do not show in version 1.4.1. (I actually don't know if they worked before because I only just made my 17th and 18th virtual tags after installing 1.4.1.)

Screenshot 2021-04-05 19 31 11

Shown in my screenshot, I have 18 virtual tags, 17 and 18 being identical. Virtual tags 1-16 all work in discordbee, no problem, when used as [Virtual1] - [Virtual16] (it doesn't take the assigned names for some reason). Virtual tags 17 and 18, however, simply show "[Virtual17]" or "[Virtual18]" when set in discordbee.

Screenshot 2021-04-05 19 36 59

I tried setting virtual tags 17 and 18 in the 2 highlighted boxes, both to the same result:

Screenshot 2021-04-05 19 26 28

Using Musicbee 3.4.7536 P, Discordbee 1.4.1

Rings4 commented 3 years ago

Okay, I think the issue isn't the update, but the fact that this plugin simply does not look for Virtual tags 17-32. I just checked placeholders and I see it stops at 16.

Screenshot 2021-04-05 19 48 12

sll552 commented 3 years ago

I see where this comes from. The plugin iterates over all fields that are available through the API, but the API seems to be a little outdated and I was using an older version. I updated it but the current version only goes to Virtual25 so its an improvement.

Those tag fields are assigned numbers and until Virtual25 they were ever increasing without gaps, but some other fields were added in between so I can't really guess those missing ids either. Is Virtual25 enough for you?

sll552 commented 3 years ago

You can try this with https://ci.appveyor.com/api/buildjobs/c4ufcqg8srxti8v2/artifacts/DiscordBee-Release-update_mb_interface-126.zip

Rings4 commented 3 years ago

You can try this with https://ci.appveyor.com/api/buildjobs/c4ufcqg8srxti8v2/artifacts/DiscordBee-Release-update_mb_interface-126.zip

image

Hmm, it seems I need to update musicbee to use this plugin. I'll look for the latest beta (since I'm already using a version newer than the latest official release) and will post back.

Rings4 commented 3 years ago

You can try this with https://ci.appveyor.com/api/buildjobs/c4ufcqg8srxti8v2/artifacts/DiscordBee-Release-update_mb_interface-126.zip

It looks like my previous reply was incorrect as I see the latest official release was actually updated today! I've went ahead and installed it and it's working great! Virtual tag 17 works, and I see placeholders for 17-25, so I assume those would also all work.

It's definitely a great improvement to be able to use Virtual tags 17-25 now! If you can manage to figure out how to implement Virtual tags 26-32 as well, I'll be really happy. You can make the virtual tags something easily distinguishable so that you can simply hunt down the values and figure out which fields correspond to which virtual tags. Something like below:

image