search

sloanelybutsurely / typeid-elixir

Elixir implementation of TypeIDs: type-safe, K-sortable, and globally unique identifiers inspired by Stripe IDs
MIT License
58 stars 8 forks source link

Update dependencies phoenix to 1.7.10 and phoenix_html to 4.0 #27

Closed patrols closed 7 months ago

patrols commented 9 months ago

Update phoenix dependencies to be compatible with phoenix_html 4.0

See changelog

sloanelybutsurely commented 9 months ago

@patrols can you please what minimum OTP and Elixir versions are needed to support this dependency upgrade?

phcurado commented 7 months ago

I think adding both versions on deps would fix this:

{:phoenix_html, "~> 3.0 or ~> 4.0", optional: true},

@sloanelybutsurely I can open another PR or we fix this one? Without this change we can't upgrade phoenix version to the lastest.

sloanelybutsurely commented 7 months ago

I think adding both versions on deps would fix this:

{:phoenix_html, "~> 3.0 or ~> 4.0", optional: true},

@sloanelybutsurely I can open another PR or we fix this one? Without this change we can't upgrade phoenix version to the lastest.

@phcurado please feel free to open another PR with your suggested change

phcurado commented 7 months ago

opened here