slocumbf / owasp-esapi-java

Automatically exported from code.google.com/p/owasp-esapi-java
0 stars 0 forks source link

Removing Newline in EncodeForHTMLTag and EncodeForHTMLAttributeTag #32

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
I am using the EncodeForHTMLTag and the EncodeForHTMLAttributeTag and have
the following change-request:

Both tags add a newline after encoding the content. This leads to
unnecessarly long HTML-pages which sometimes produce rendering problems in
some browsers. Here is an example of the html-output:

</option>
          <option value="Personal &amp; Household Goods
">
                Privat &amp;amp&#59; Haushaltswaren

</option>
          <option value="Oil &amp; Gas
">
                &Ouml;l &amp;amp&#59; Gas

Replacing 
  out.println( e.encodeForHTML(content) ); 
with
  out.print( e.encodeForHTML(content) );
would solve the problem. 

Original issue reported on code.google.com by wettstei...@gmail.com on 7 Oct 2009 at 8:11

GoogleCodeExporter commented 9 years ago
Furthermore I would be very thankful if tags for the others encoding methods 
could be
written (for example encodeForURL). 

Original comment by wettstei...@gmail.com on 7 Oct 2009 at 8:41

GoogleCodeExporter commented 9 years ago
This got fixed by one of my patches that got committed recently and I think 
this can
be closed.

In relation to comment 1, I have these implemented and should be posting a patch
sometime today. If you need them sooner, drop me an email.

Original comment by schal...@darkmist.net on 16 Oct 2009 at 1:14

GoogleCodeExporter commented 9 years ago
Patch for other encoding methods and EL functions now posted in issue 38

Original comment by schal...@darkmist.net on 17 Oct 2009 at 4:59

GoogleCodeExporter commented 9 years ago
Thanks very much!

Original comment by wettstei...@gmail.com on 19 Oct 2009 at 7:28

GoogleCodeExporter commented 9 years ago
closed - this was fixed with issue 35

Original comment by chrisisbeef on 23 Oct 2009 at 4:15