sloev / python-lambdarest

Flask like web framework for AWS Lambda
https://sloev.github.io/python-lambdarest/
MIT License
94 stars 23 forks source link

support for multiValueQueryStringParameters #71

Closed sloev closed 4 years ago

sloev commented 4 years ago

Hey @sloev Indeed this is just for arrays, or multi-value query string parameters. Actually i wonder if this change can be made at the same time as potentially adding support for the multiValueQueryStringParameters field within the event object. this field is supported for both API Gateway and ALB and its actually something I looked for in terms of support initially vs comma-seperation. This would allow for foo&bar&foo=bar2 type query strings.

In this way comma-seperation float conversion can be left as is, and multiValueQueryStringParameters support can be added that either does not perform type casting or attempts to use the schema definition (if it exists) to convert to the appropriate type (string, integer, float)

I'm happy to have a go at adding support for multiValueQueryStringParameters if you feel it's something you would accept.

Originally posted by @andyfase in https://github.com/trustpilot/python-lambdarest/issues/69#issuecomment-689122693

sloev commented 4 years ago

closing this issue cuz it hasnt got any traction (out in the wild)