search

slog-rs / async

Asynchronous drain for slog-rs v2
Apache License 2.0
28 stars 24 forks source link

Avoid thread kill via panic #31

Closed kryvashek closed 1 year ago

kryvashek commented 1 year ago

We have encountered a situation when the inner task of async drain had been killed with a panic due to lack of free space on the device. It would be great to see some useful infromation about this case when it happens and have the thread stopped more gracefully. Changes provided within this PR are intended to help with described issues.

eprintln is used to output information about encountered errors since the intended way of logging obviously doesn't work correctly in related cases.

dpc commented 1 year ago

Seems reasonable.

kryvashek commented 1 year ago

@dpc Hope so.

Should I take any other action with this PR?

dpc commented 1 year ago

Ping @Techcable

kryvashek commented 1 year ago

@Techcable, hello!

Sorry for disturbing. Could you please review this PR? I've already sent you email about it.

Techcable commented 1 year ago

@Techcable, hello!

Sorry for disturbing. Could you please review this PR? I've already sent you email about it.

I am so sorry about the slow response. Unfortunately, I was having some trouble with school which made it tough to review PRs.

I will merge this right away now :)

kryvashek commented 1 year ago

I will merge this right away now :)

Thank you very much! (=