search

slog-rs / slog

Structured, contextual, extensible, composable logging for Rust
https://slog.rs/
Apache License 2.0
1.58k stars 95 forks source link

Run `cargo fmt` #297

Closed Techcable closed 2 years ago

Techcable commented 2 years ago

All the changes here are automatic (except for this message).

Right now my Github Actions (slog-rs#295) has 'cargo fmt -- --check' always succeed (showing a green checkmark) even if there are formatting errors.

With your permission, I would like to enable rustfmt by default for Github actions.

This means that it would show a red checkmark and "fail" if there are formatting errors (as opposed to always succeeding ).

It's separate from the main "test" workflow, so it would not be required for PRs to merge, it would just show a warning.

I'm marking this as a Draft because:

  1. I want to switch to GitHub actions first (merge #295)
  2. I want your permission to enable the rustfmt action by default.
Techcable commented 2 years ago

@dpc Just to be clear, you're okay if I change GH actions to run this by default? It's just cargo fmt -- --check, no automatic changes.

dpc commented 2 years ago

:+1:

Techcable commented 2 years ago

Okay! The new GH actions rustfmt check works properly!

I intentionally created a formatting problem and GH actions caught it :)