slog-rs / slog

Structured, contextual, extensible, composable logging for Rust
https://slog.rs/
Apache License 2.0
1.58k stars 95 forks source link

ci: Use auguwu/clippy-action@1.4.0 to run clippy #339

Closed Techcable closed 2 months ago

Techcable commented 2 months ago

Makes clippy warnings trigger warnings instead of hard errors, fixing issue #338

HACK: Use my fork of auguwu/clippy-action to support "features" input.

Split off from PR #337 , which is logically independent.

A couple issues:

The --features flag isn't working when used with check-args
We get lots of duplicate warnings by running multiple feature combinations

IDEA: Maybe run just once with --all-features?

Make sure to:

Techcable commented 2 months ago

I decided we want build failures on warnings, as discussed in #338

We only trigger build failures on warnings on the "hardcoded recent stable," so clippy changes shouldn't unexpectedly fail the build.