sloisel / numeric

Numerical analysis in Javascript
http://www.numericjs.com/
Other
1.42k stars 176 forks source link

numeric.T.eig looks suspicious #61

Open gagern opened 9 years ago

gagern commented 9 years ago

The numeric.T.eig function, as implemented in 610f2503976af62df5b650af9298d34043664dc0, looks suspicious: either it's an instance method, then it belongs into numeric.T.prototype.eig. But in that case I don't understand its semantics, since you can't reasonably compute eigenvalues of a single complex number. Or it's a class method, then it should not refer to this. And to make sense semantically, it should probably also take a complex-valued matrix as an argument. I see noone using this function at all, so unless there is actually a use case for this, you might also consider deleting it.