search

slok / sloth

🦥 Easy and simple Prometheus SLO (service level objectives) generator
https://sloth.dev
Apache License 2.0
2.06k stars 167 forks source link

Consider support the Bad metrics from OpenSLO #186

Open weyert opened 2 years ago

weyert commented 2 years ago

Recently the OpensLO added support to allow defining bad / totals metrics for SLO. See also this commit in OpensLO repo: https://github.com/OpenSLO/OpenSLO/commit/02257252e5d25b755d6285ee7bd4734ded9dd9cb

I was curious what's involved to add support for this into Sloth? Do you think this is achievable for someone who doesn't have any Go programming experience (me)?

slok commented 2 years ago

Hi @weyert!

Thanks for the update, we could add support indeed. You could give it a try indeed. I think that is not hard and a good exercise. I can point you to the place where this is happening (without telling you exactly so you can learn :smile:) and give it a shot.

If it's taking too much time or you are lost I can do it myself and explain the PR to you if you want.

For now... https://github.com/slok/sloth/tree/main/internal/openslo

weyert commented 2 years ago

Thank you, @slok. Sounds like a plan!