New recording rule is created when adding a label to the existing PrometheusServiceLevel

slok / sloth

🦥 Easy and simple Prometheus SLO (service level objectives) generator

https://sloth.dev

Apache License 2.0

2.06k stars 167 forks source link

New recording rule is created when adding a label to the existing PrometheusServiceLevel #281

Open pcperera opened 2 years ago

pcperera commented 2 years ago

Issue

Sloth generates a new recording rule when adding a label to the existing PrometheusServiceLevel spec.

Repro

Create PrometheusServiceLevel and deploy
Verify recording rule is created.
Add a new label to PrometheusServiceLevel spec and deploy.

Expected

Existing recording rule is amended.

Actual

A new recording rule is created with the new label.

slok commented 2 years ago

Hi @pcperera!

Regarding the data-series, that's how Prometheus works, however, if you are speaking about the visual Grafana dashboard, eventually that old metric will disappear when those metrics are no longer part of your time range.

pcperera commented 2 years ago

Thanks @slok !