slonopot / Beenius

A proper Genius lyrics provider for MusicBee
34 stars 1 forks source link

Error searching for japanese artist #2

Closed tmatzxzone closed 1 year ago

tmatzxzone commented 1 year ago

Can you add romanized lyrics for japanese artist too?


2022/11/26 07:50:17.871 | Info | Beenius.GeniusClient.getLyrics | Attempting to search for "さユり" - "酸欠少女"
2022/11/26 07:50:17.887 | Debug | Beenius.GeniusClient.search | artist="さユり", title="酸欠少女"
2022/11/26 07:50:18.650 | Info | Beenius.GeniusClient.search | Let's check for aliases
2022/11/26 07:50:19.535 | Info | Beenius.GeniusClient.search | No aliases
2022/11/26 07:50:19.542 | Info | Beenius.GeniusClient.search | No results for this search
2022/11/26 07:50:19.542 | Info | Beenius.GeniusClient.getLyrics | Nothing found at all ```
slonopot commented 1 year ago

This query should probably hit this if you set delimiters=["("] and trimTitle=true. Then, there are romanizations available separately for さユり and if that's what you need then I'll have to think how can I manage to do this. For さユり - ミカヅキ you can try to set allowedDistance=50 and see if it will get you a romanized version since it's the first one in the search results.

Additionally, lyrics in Japanese seems to be available in Musixmatch without any additional conversions, you can try my other addon and see if it fits you.

slonopot commented 1 year ago

Now that I think about it, one of the options could be to add something like this, check if the text is in Japanese and romanize it automatically. I'm still not sure if it's necessary to add it to the build since the thing is very specific.