search

slonopotamus / stevedore

🚢 Docker distribution for Windows Containers that Just Works
Apache License 2.0
305 stars 12 forks source link

dockerd.exe missing after choco upgrade #34

Closed Hvid closed 2 years ago

Hvid commented 2 years ago

Stevedore Version

0.3.2

Windows Version

Microsoft Windows [Version 10.0.20348.524]

Log output

stevedore.log

Additional context

Previously running 0.0.6. Did a choco upgrade stevedore -y via puppet and rebooted afterwards. dockerd.exe is missing after the upgrade and service cannot start.

If i force another upgrade to the same version, it works. Maybe the service isn't stopped correct and then the file cannot be overwritten? It is deleted though.

Note: the service name is 'docker' for this install.

slonopotamus commented 2 years ago

So, this is 0.0.6 -> 0.3.2 upgrade while the service was running? I'll try to reproduce that locally... Though the service is supposed to be stopped by installer during upgrade =/

Hvid commented 2 years ago

Yes., exactly. I was thinking that maybe the stop fails due to the service being renamed in the first place.

Hvid commented 2 years ago

Also, this was with puppet, so executed by localsystem user.

slonopotamus commented 2 years ago

This might be caused by the fact that dockerd MSI component doesn't have a fixed GUID... Will try using some fixed value. Note that the same thing can happen once more when you will be upgrading from non-fixed GUID to fixed one, but should not occur after that (if it will still happen, this issue will need to be reopened).

Hvid commented 2 years ago

Okay, let me know when when and how to test it :)

slonopotamus commented 2 years ago

I've reproed this issue. You're right, 0.0.6 -> 0.3.2 upgrade wipes away dockerd.exe. Workaround: reinstall/repair 0.3.2.

slonopotamus commented 2 years ago

Fix released as stevedore-0.3.3. Might take some time to be published on GH releases / Chocolatey. As I said, you might notice one more dissapearing of dockerd.exe when updating from <0.3.3 to >=0.3.3, but this should never happen again after that 0.3.3.

Hvid commented 2 years ago

Hey, just wanted to let you know that dockerd.exe did not get removed during the upgrade from 0.3.2 to 0.3.3.