search

slope-it / breadcrumb-bundle

A bundle for generating dynamic breadcrumbs in Symfony applications
Other
10 stars 4 forks source link

Issue #8: Improve route generation by using UrlGenerator's request context #17

Closed asprega closed 2 years ago

asprega commented 2 years ago

This allows to only re-use route path attributes when they are needed by the route being generated. Previous method, instead, always set them as explicit parameters -- this caused extra query string parameters whenever a path attribute of the "parent" route wasn't present in the route being generated.

Jupi007 commented 2 years ago

It works, there's no more unneeded parameters. Thanks very much!

asprega commented 2 years ago

Good to hear! Please give me a couple days for fixing tests and adding some more, and then I will release a new tagged version so you can install it in your project. Thanks :)