search

slopp / connectApiUtils

Experimental
4 stars 1 forks source link

Easy deploy #2

Closed colearendt closed 5 years ago

colearendt commented 6 years ago

Add utilities to make programmatic deployment easier

Questionable because it acquires a hard dependency on fs and a soft dependency on rsconnect for the snazzy new writeManifest function.

Also poll_task could use some love :smile: And the docs/tests could use love...

<rant>RStudio not putting terminating new lines at the end of files is driving me nuts </rant>

One downside of dir_bundle as currently written - it can include the old bundle.tar.gz in the new bundle.tar.gz... should ideally remove any .tar.gz files before using utils::tar, but utils::tar is a little finnicky about files and such...

colearendt commented 6 years ago

@slopp You mentioned some of this functionality belongs in rsconnect. Until we have it there, does it make sense to merge this PR / revise it in some way (maybe keep the functions from being exported?) / drop it?

slopp commented 6 years ago

@colearendt I'd prefer if we referenced the non-exported rsconnect functions, https://github.com/rstudio/rsconnect/blob/master/R/bundle.R

That way we're not duplicating (with lots of missing pieces) parts of this code, and we can easily switch to exported functions once they are available.

colearendt commented 5 years ago

Removed the dir_manifest function. We should merge so we can iterate on this improved / granular deploy workflow