search

sloppycoder / nfsx

building blocks for creating http based micro service using Spring Boot and Netflix OSS
4 stars 5 forks source link

Unable to merge spring-session branch into master #16

Closed sloppycoder closed 8 years ago

sloppycoder commented 8 years ago

78092df1c4c0168a40c57298932d8bdd4159caae

adding spring-boot-starter-redis dependency onto class path will trigger spring-boot to initialize redis connectivity, which fails when redis is not running. this happens even when spring-session @EnableRedisHttpSession is not present anywhere in the code.

This behavior basically prevent merging spring-session support into master because it makes all the tests dependent on Redis. Though it is possible to use embedded redis to support testing it is undesirable since it requires extra code in all modules but without much benefits.

It will be desirable to merge spring-session support into master, and enable it with a configuration item in application.yml.

sloppycoder commented 8 years ago

b56a9afb5a92e4dece3edcd24e4f92cb876ae903

spring-session feature merged into master. since it's only used for web app module alone change test cases is relatively small amount of work.

Not an ideal solution but it will do for now.