slor8 / iBookTracker

0 stars 0 forks source link

Peer Code review #5

Open mbarnett1 opened 6 years ago

mbarnett1 commented 6 years ago

Design/Code Review 1

Project: iBook

Developer: See

Reviewer: Mike Barnett

Item	Considerations	Comments/Suggestions
Reviewer comments and suggestions go here. Each item should have at least one "kudos" and two suggestions for improvement
Problem Statement	1. Accurately describes project purpose 2. Is professional and free of typos, slang, etc. 3. Fully explains the problem and the solution 4. Is understandable by the average person	Problem statement well done. Application is pratical, it could be used for outside libraries people have. The application be used for more than just books! Movies, videogames, etc!
Design Documentation	1. Navigation/flow through the application is logical and easy to use. 2. The order in which values are displayed are logical and easy to understand/use 3. The order in which the form fields entered are logical and easy to understand/use 4. All data discussed/documented (problem statement, flow, db design, etc.) is represented on the screens	Screen flow done well, nice colorful screens. Nice detailed screens, I like how you can see where your books are. Looks easy to use on a phone.
Data model/Database	1. Everything on the screens and problem statement/flow is represented in the model 2. There is at least one 1-to-many relationship. 3. The model represents good database design	Daos looked good. All requirments met, one to many implemented well. Needs documentation for database.
Code	1. Proper Maven project structure is used 2. a .gitignore file for IntelliJ Java projects has been implemented 3. There is not any redundant or copy/paste code in the JSPs or classes 4. Classes are appropriately-sized (no monster classes) Property files are used appropriately: no hard-coded values 5. Logging statements are used rather than System.out.println and printStackTrace. 6. There are appropriate unit tests/code coverages.	Classes straightfoward and logical. Not sure how issue book works. Make a class to add friends? Still need to implement jsps.

pawaitemadisoncollege commented 6 years ago

@mbarnett1 You did a good job offering Kudos. How about some areas for improvement in the first two categories?