search

slorber / gatsby-plugin-react-native-web

react-native-web plugin for Gatsby
https://sebastienlorber.com/using-expo-in-gatsby
MIT License
276 stars 30 forks source link

Migrate to v2 #4

Closed rickiesmooth closed 5 years ago

rickiesmooth commented 6 years ago

sorry that I didn't give any description, but in order to use the latest version of gatsby, I've fixed the following issue: https://github.com/slorber/gatsby-plugin-react-native-web/issues/3

If I need to change something please let me know :)

minheq commented 5 years ago

@slorber please merge :)

minheq commented 5 years ago

@rickiesmooth i believe that u also need to change ES imports to CommonJS https://www.gatsbyjs.org/docs/migrating-from-v1-to-v2/#convert-to-either-pure-commonjs-or-pure-es6

I made a PR: https://github.com/rickiesmooth/gatsby-plugin-react-native-web/pull/1

slorber commented 5 years ago

Hey thanks! didn't get any notification about your PR sorry for the delay

slorber commented 5 years ago

@minheq can you explain the problem with imports? Why not use ES imports everywhere instead of commonjs?

slorber commented 5 years ago

I've just published 2.0.0-alpha.0, don't have time to test it.

If you want to become contributor on this repo tell me, I may not have time to maintain it correctly until the end of the year