search

slorber / gatsby-plugin-react-native-web

react-native-web plugin for Gatsby
https://sebastienlorber.com/using-expo-in-gatsby
MIT License
277 stars 30 forks source link

Fix/fix with latest Gatsby v3 #65

Closed Daavidaviid closed 3 years ago

Daavidaviid commented 3 years ago

I added a new-example using :

There is an issue with withUnimodules so I had to patch it temporarily @expo+webpack-config+0.12.66.patch.

To try it, just do : 

yarn
yarn link

cd examples/new-example
yarn link gatsby-plugin-react-native-web
yarn
yarn start

Then to build it do : 

yarn build

I think the only issue is with withUnimodules that needs to be updated to work with Gatsby

Daavidaviid commented 3 years ago

@slorber you might be interested

slorber commented 3 years ago

Thanks @Daavidaviid

Unfortunately, I don't have much time to maintain this package, do you want to help and have access?

I'm not 100% sure but I feel like using patch-package is not a good solution. Will the patch be applied correctly if someone loads the lib from npm?

Also, why is the example named "new example", that seems a bit weird, maybe it's possible to find a more meaningful name?

Updated the CI to node 14 so that Netlify can run, but it seems unable to built the uikits examples currently: https://app.netlify.com/sites/gatsby-rnw-uikits/deploys/60883d8d60706581850fca14

Daavidaviid commented 3 years ago

Thanks @Daavidaviid

Unfortunately, I don't have much time to maintain this package, do you want to help and have access?

I'm not 100% sure but I feel like using patch-package is not a good solution. Will the patch be applied correctly if someone loads the lib from npm?

Also, why is the example named "new example", that seems a bit weird, maybe it's possible to find a more meaningful name?

Updated the CI to node 14 so that Netlify can run, but it seems unable to built the uikits examples currently: https://app.netlify.com/sites/gatsby-rnw-uikits/deploys/60883d8d60706581850fca14

I decided to look into next.js 👀