Open StefanWallin opened 3 months ago
The return type is Promise<void>
indeed because the function is async, this is a perfectly ok return type for an async function that doesn't return anything meaningful
Now you are free to add an await if you care:
const scrollIntoView = useScrollIntoView()
const scrollMembers = async () => {
if (membersRef && membersRef.current && memberFilter.length > 0) {
await scrollIntoView(membersRef.current)
}
}
Whenever I use the scrollIntoView-function that is returned from the
useScrollIntoView
-hook I get an ESlint error called@typescript-eslint/no-floating-promises
.The reason for this seem to be that the function is typed to return a Promise but is not returning anything .
The result of this is that any attached
catch
will not work sincecatch is not defined on undefined
.@typescript-eslint/no-floating-promises
My own research leads me to think this might be related to Hermes not supporting Async arrow functions. But this code below snippet does work, so it's not apparent for me.
Details
(I've fixed it with ignore next line, but thought it might be interesting to know)