sloukit / pydew-valley-uzh

Mod of Pydew Valley for an experimental study in Psychology
Creative Commons Zero v1.0 Universal
32 stars 61 forks source link

Bug fix - flickering transparent player/npc #197

Closed tomkommando closed 1 month ago

tomkommando commented 1 month ago

Summary

This PR fixes the bug reported in this issue: https://github.com/sloukit/pydew-valley-uzh/issues/147

Bumped into this bug myself and realised there was an issue raised as well.

The flickering happens because all characters reference to same instance of assets. If player starts to become transparent, alpha value of a frame is changed. This frame is be used by all other bunnies as well which causes inconsistent alpha values and therefore the flickering.

This is now resolved by passing a copy of the images for each bunny instead of a reference. A quick fix.

Checklist

Labels

game-art, game-gameplay, game-playtesting