sloukit / pydew-valley-uzh

Mod of Pydew Valley for an experimental study in Psychology
Creative Commons Zero v1.0 Universal
32 stars 61 forks source link

Additional features minigame #210

Closed luvdamuzik closed 3 weeks ago

luvdamuzik commented 1 month ago

Summary

Added 2 NPCs (very easy to add more) that cheer during the minigame.

I moved the init of emote_manager from NPC to NPCBase so it can be used in NPCIndividualContext. Made the NPC Idle and cheer from time to time. (In testing the best looking probability for cheering was 1/500)

Checklist

Questions

  1. What if the player is outgroup? Shouldnt the NPCs cheering be also outgroup?
  2. Same logic applies to the opponent's group?
  3. How many NPCs should be cheering?
  4. To explain the Change wording when displaying score: "Your Group won!", no singular specifically the no singular part?
michelfinley commented 1 month ago

First of all - good job linking all those different parts of the codebase together!

1/2. I'd say so! I imagine it would look nice if the outgroup-player would also switch to the right-hand / "outgroup" side on the minigame map. In that case the cheering characters won't have to switch sides on their own, though I do not know if that's really possible. I am unsure whether or not both halves of the minigame map can be identically mirrored so that the opponent's AI would behave the same regardless of the side.

  1. I think you can't yet say how many NPCs would fit best. Two - as you have implemented - already suit really well to not make the screen look too cluttered or draw the player's attention too much, though I guess that it is subject to testing and individual player feedback to really tell how many cheering NPCs look best.

  2. I believe @sloukit wanted to emphasize on the player's group affiliation and avoid making it seem like the player competes directly against their individual opponent. To me the plural form makes it seem more like a small battle between both groups as a whole

Hope I could help :D

sloukit commented 1 month ago

@luvdamuzik great job, thanks! I think it would be nice to have at least 5 ingroup members next to the fence (as @michelfinley rightly said, the main idea of this thing is to create an atmosphere of "battle between groups", which should strengthen group affiliation – the more ingroup members there are, the better. Your cheering looks perfectly fine to me.

luvdamuzik commented 1 month ago

Great i added 5 NPCs per group on their respective sides and also made it so that the player depending on study group spawns on the correct side. Same as the opponent. Now that is left is to make the cows collidable on the outgroup side and the AI for the opponent.

sloukit commented 1 month ago

Perfect! The only thing that could be adjusted: @luvdamuzik Could you change the state of the camera, zoom it out a bit more, so that the player always sees the outgroup members next to the fence on the right?