fix(debug-overlays): Fix hitbox and pf overlay sometimes being offset

sloukit / pydew-valley-uzh

Mod of Pydew Valley for an experimental study in Psychology

Creative Commons Zero v1.0 Universal

32 stars 61 forks source link

fix(debug-overlays): Fix hitbox and pf overlay sometimes being offset #217

Closed michelfinley closed 3 weeks ago

michelfinley commented 1 month ago

Summary

This PR fixes debugging overlays sometimes being offset as described in issue #143 .

Checklist

[X] I have tested this change locally and it works as expected.
[X] I have made sure that the code follows the formatting and style guidelines of the project.

Labels

type: bugfix, game-playtesting

DangerousVanilla commented 1 month ago

Looks like this is working well in all but one case I found - when the camera zooms in. It does recover to the correct position, just doesn't scale with zoom. Looks like that was a previously existing issue though and this PR does indeed fix everything listed in the bug. I suppose I'll open a new one for scaling issue.

Here's a little clip of what I'm referring to: https://github.com/user-attachments/assets/8ae63e66-1c9c-45c4-bdc0-d7371f7a0d22

michelfinley commented 1 month ago

@DangerousVanilla Nice catch! To resolve the issue only two lines had to be moved, no need for a new PR 😄