Mute the new issue not found slack notification on weekends (#6).

slovensko-digital / uvobot

8 stars 7 forks source link

Closed martinsabo closed 8 years ago

jsuchal commented 8 years ago

Rozmyslam ci je toto zodpovednost notifiera. Podla mna by sa nemala ziadna sprava ani len posielat ak vestnik nevysiel. Cize o poschodie vyssie. Hm?

martinsabo commented 8 years ago

Pravda. Dam to na starost workeru.

martinsabo commented 8 years ago

Chcelo by to ten spolocny test, co overuje ci notifier implementuje spravne interface.

jsuchal commented 8 years ago

To mi pride take suplovanie interfacu z javy. Skor tam chyba test, ze new_issue_not_published nerobi nic. Tam by sa to odhalilo.

Inak ak chces zazit srandu tak si daj toto

$ gem install mutant
$ mutant --include lib --use rspec Uvobot::Notifications::DiscourseNotifier

A uvidis ake su tie testy derave. :D

martinsabo commented 8 years ago

Skusil som ten shared example.

jsuchal commented 8 years ago

@martinsabo Ja uz som to mergol.