search

slovnicki / beamer

A routing package built on top of Router and Navigator's pages API, supporting arbitrary nested navigation, guards and more.
MIT License
582 stars 128 forks source link

Correct handling of new URI API (fixes Deep Link Handling) #660

Closed Bungeefan closed 3 months ago

Bungeefan commented 3 months ago

This PR intends to fix #654 by correcting the usages of uri.toString() with uri.path.

The first commit would technically be sufficient to fix the issue, however, I would strongly recommend to also consider pulling in the second commit as it migrates some of the internal usages to the more appropriate URI API to prevent future mistakes while handling paths.

I also added additional tests to prevent future regressions of this type and tried to restore the behavior as close as possible as it was before bfe7ce3cc7c9f2c08bd62a4845da883a4213c1d0.

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 95.83333% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 97.10%. Comparing base (dcda31e) to head (c70aca7).

Files Patch % Lines
package/lib/src/beamer_delegate.dart 83.33% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #660 +/- ## ========================================== - Coverage 97.11% 97.10% -0.02% ========================================== Files 14 14 Lines 902 897 -5 ========================================== - Hits 876 871 -5 Misses 26 26 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

stan-at-work commented 3 months ago

Thank you for the PR @Bungeefan! 💙

LGTM, I'll proceed with the merge and will publish a new version to pub.

Are you still actively working on the package ?

slovnicki commented 3 months ago

Hey @stan-at-work

Yes, I'm still working on the package, but at much slower pace currently. Hopefully, the pace will increase. I wrote more details in this issue (which is maybe also yours): https://github.com/slovnicki/beamer/issues/659#issuecomment-1991349705

Sten435 commented 3 months ago

Hey @stan-at-work

Yes, I'm still working on the package, but at much slower pace currently. Hopefully, the pace will increase. I wrote more details in this issue (which is maybe also yours): #659 (comment)

Correct, thanks for the response