search

slowe / Chromoscope

Chromoscope lets you explore our Galaxy (the Milky Way) and the distant Universe in a range of wavelengths from X-rays to the longest radio waves.
http://www.chromoscope.net/
39 stars 8 forks source link

KML pins are not being populated #37

Closed ebressert closed 13 years ago

ebressert commented 13 years ago

The KML pins are not being loaded in the latest commit. Using Firebug shows that no new pins are being created.

slowe commented 13 years ago

KML pins get loaded on my local copy and on the dev site (both are on the latest copy of the code). Can you check with Firebug to see if the XML request is successful? It may be that the XML request is failing to provide KML response.

slowe commented 13 years ago

I've had a re-think of how the pins are done in the dev version. Rather than creating separate layers there is now just one pin layer so you can now just add a pin without creating a pin layer first: this.addPin({title:"A title",desc:"A description",glon:23.4,glat:20.8,width:330});

However, you can group pins if you want to. To create a group: group = this.addPinGroup({id:'lookupresults',title:'Search results'});

Then add a pin to it: this.addPin({group:group,title:"A title",desc:"A description",glon:23.4,glat:20.8,width:330});

This is probably, conceptually, clearer but I'm not sure if it'll be a little slower as it relies on using class names.

slowe commented 13 years ago

This problem seems to be fixed so I'm going to close this issue.