search

slowlydev / f1-dash

A real-time F1 dashboard
https://f1-dash.com
GNU General Public License v3.0
412 stars 39 forks source link

New record colors #52

Closed AdriCardenas closed 4 months ago

AdriCardenas commented 4 months ago

Improve color of the text and background of the mini sectors and the times of a pilot

vercel[bot] commented 4 months ago

Someone is attempting to deploy a commit to a Personal Account owned by @Slowlydev on Vercel.

@Slowlydev first needs to authorize it.

vercel[bot] commented 4 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
f1-dash ✅ Ready (Inspect) Visit Preview ✅ 1 resolved Feb 23, 2024 10:45am
slowlydev commented 4 months ago

Thanks for the PR. I think the background color in LeaderBoard.tsx is still the old purple, could you also adjust that?

AdriCardenas commented 4 months ago

Hi,

Thanks for the PR. I think the background color in LeaderBoard.tsx is still the old purple, could you also adjust that?

I review the LeaderBoard.tsx file but i have not found colors on it. Just the bg-gray-700 on the skeleton.

slowlydev commented 4 months ago

Hi,

Thanks for the PR. I think the background color in LeaderBoard.tsx is still the old purple, could you also adjust that?

I review the LeaderBoard.tsx file but i have not found colors on it. Just the bg-gray-700 on the skeleton.

nevermind, my bad, it should be in the Driver.tsx

slowlydev commented 4 months ago

Also maybe violet could match better, because as you said the original color was kind of blueish, and that was because all other ui elements have a slight blue tint.

image
AdriCardenas commented 4 months ago

Also maybe violet could match better, because as you said the original color was kind of blueish, and that was because all other ui elements have a slight blue tint.

image

Sure, i had that doubt. I'll change it in a new commit because both of them are good.

AdriCardenas commented 4 months ago

What is the meaning of minisector blue color?

"bg-blue-500": status === 2064

AdriCardenas commented 4 months ago

What is the meaning of minisector blue color?

"bg-blue-500": status === 2064

Should be on the help tab. I think that it is enter and exit of boxes.

slowlydev commented 4 months ago

What is the meaning of minisector blue color?

"bg-blue-500": status === 2064

Should be on the help tab. I think that it is enter and exit of boxes.

Yes thats true.

slowlydev commented 4 months ago

thanks for the adjustments, looks good to me 😄