search

slowscript / warpinator-android

An unofficial implementation of Warpinator for Android
GNU General Public License v3.0
481 stars 29 forks source link

UI Work #7

Closed rares45 closed 3 years ago

rares45 commented 3 years ago

I have redone the UI as in #5. I also added the about activity. screenshot1screenshot2

And the rest:

screenshot3screenshot4screenshot5

Btw, I dropped the gesture part. It was too hard to make without 3rd party libraries and it wasn't that intuitive. I think the only swipe gesture should be to remove the transferView after it is done.

rares45 commented 3 years ago

@slowscript what do you think?

slowscript commented 3 years ago

Hi, it has been a busy few days for me again. Sorry about that. Here's a short review:

I appreciate the time you are putting into this. The design looks great! Only two nitpicks this time: -The animation is a bit too slow, duration should be same as system animations -I don't see why the background color needs to be different in light mode. I think most users expect at least the basic color scheme to be standardized across apps.

rares45 commented 3 years ago

About the animation. You are right. What's the duration of system animations? About the color, I wanted to evidence the transfers panel. To be honest I never tried with a white background. Gonna try and fix the animation.

rares45 commented 3 years ago

I made the animation last 300 instead of 550. And made the white more white

slowscript commented 3 years ago

Thanks. Will merge now.