search

slowtec / modbus-core

A pure no-std Rust modbus library
Apache License 2.0
40 stars 16 forks source link

make codec + Encode public #11

Closed pythcoiner closed 3 months ago

pythcoiner commented 5 months ago

fixes #1

zeenix commented 3 months ago

@flosse do you plan to review this PR in the near future? We are maintaining a downstream fork in our company just for this change and another oneliner (that we'd love to contribute upstream as well) on top. Ideally we'd love to just use this crate as-is from crates.io (or git even is fine).

flosse commented 3 months ago

@flosse do you plan to review this PR in the near future?

sure!

We are maintaining a downstream fork in our company just for this change and another oneliner (that we'd love to contribute upstream as well) on top.

Feel free to open a PR!

Ideally we'd love to just use this crate as-is from crates.io (or git even is fine).

sure.

Would you mind to contribute a little example how you use this crate?

zeenix commented 3 months ago

@flosse do you plan to review this PR in the near future?

sure!

Awesome!

We are maintaining a downstream fork in our company just for this change and another oneliner (that we'd love to contribute upstream as well) on top.

Feel free to open a PR!

Thanks. I'm on vacation this week so either my colleague will do that or I'll do it after I'm back.

Would you mind to contribute a little example how you use this crate?

I'll have to ask but if it's possible, I'll definitely do that. 😊