Try implementing CI features - [merged]

slrtbtfs commented 1 year ago

Merges ci -> main

should fix #3, but we have to wait until our tests are fixed to see if coverage works

Signed-off-by: Tobias Guggenmos tobias.guggenmos@uni-ulm.de

slrtbtfs commented 1 year ago

In GitLab by @bjthehun on Nov 10, 2022, 10:24

requested review from @bjthehun

slrtbtfs commented 1 year ago

In GitLab by @bjthehun on Nov 10, 2022, 10:24

unassigned @bjthehun

slrtbtfs commented 1 year ago

In GitLab by @bjthehun on Nov 10, 2022, 10:29

Commented on .gitlab-ci.yml line 21

Clippy Doc suggests that we could let the pipeline fail when it finds something to complain (add parameter -- -D warnings. Opinions?

slrtbtfs commented 1 year ago

In GitLab by @bjthehun on Nov 10, 2022, 10:39

Commented on .gitlab-ci.yml line 33

Test stage is redundant when using grcov, because we run tests for code coverage.

slrtbtfs commented 1 year ago

In GitLab by @bjthehun on Nov 10, 2022, 10:47

Commented on .gitlab-ci.yml line 51

grcov supports cobertura format on its own; don't need lcov_cobertura (https://lib.rs/crates/grcov#readme-alternative-reports).

slrtbtfs commented 1 year ago

In GitLab by @bjthehun on Nov 10, 2022, 10:51

Commented on .gitlab-ci.yml line 54

HTML report should be an artifact

slrtbtfs commented 1 year ago

In GitLab by @bjthehun on Nov 10, 2022, 10:55

Commented on .gitlab-ci.yml line 37

Change to -Cinstrument-coverage; see grcov docs

slrtbtfs commented 1 year ago

added 10 commits

1b3461e7 - Issue #7
68a120a6 - Attempting to fix Borrow Error
9fcbace1 - WIP: try fixing lifetimes
01b9d72b - Fix the lifetime Problems
73a29d8c - Use references for node weights again
63be6dc3 - cargo fmt
420821fe - Person Type is now enum; make_sample_graph has enums (no references) as node values.
dd3f28a2 - remove unnecessary boxes
0a079354 - remove unnecessary copy traits
d27cfd7b - Try implementing CI features

Compare with previous version

slrtbtfs commented 1 year ago

added 9 commits

d27cfd7b...db7f5881 - 8 commits from branch main
04dd75f6 - Try implementing CI features

Compare with previous version

slrtbtfs commented 1 year ago

changed this line in version 5 of the diff

slrtbtfs commented 1 year ago

added 1 commit

928ba331 - directly produce cobertura report with grcov

Compare with previous version

slrtbtfs commented 1 year ago

changed this line in version 6 of the diff

slrtbtfs commented 1 year ago

added 1 commit

af793bc3 - use rustc flags recommended by grcov docs

Compare with previous version

slrtbtfs commented 1 year ago

The test stage runs with rust stable while the coverage stage runs with unstable and some extra flags set. If there are subtle differences between those compiler versions (and the features they have enabled) we wouldn't catch them when eliminating the test stage.

slrtbtfs commented 1 year ago

added 1 commit