Print Graphs to .svg - [merged] #55

Closed slrtbtfs closed 1 year ago

In GitLab by @bjthehun on Nov 17, 2022, 17:55

_Merges graphvis -> main

In GitLab by @bjthehun on Nov 17, 2022, 17:55

requested review from @slrtbtfs

In GitLab by @bjthehun on Nov 18, 2022, 10:23

added 44 commits

4a45f5f5...4c6ee962 - 43 commits from branch main
b9d7e3ca - Merge branch 'main' into 'graph_vis'

Compare with previous version

please use raw string literals here, that avoids all the escaping

Can we document this dependency somewhere more visible (e.g. a central README) and maybe even fail the build if it isn't present (using build scripts).

is there a specific reason for not using block comments (/** */)?

was this file comitted intentionally or is it supposed to be generated by tests?

is there a reason whitespaces in thist string are problematic?

In GitLab by @bjthehun on Nov 18, 2022, 16:13

Commented on tests/test_print.rs line 16

changed this line in version 3 of the diff

In GitLab by @bjthehun on Nov 18, 2022, 16:13

Commented on tests/persons.svg line 1

changed this line in version 3 of the diff

In GitLab by @bjthehun on Nov 18, 2022, 16:13

Commented on tests/person_graph_types.rs line 94

changed this line in version 3 of the diff

In GitLab by @bjthehun on Nov 18, 2022, 16:13

added 1 commit

83e1b57c - Address Code Review

Compare with previous version

In GitLab by @bjthehun on Nov 18, 2022, 16:14

Commented on tests/test_print.rs line 16

Done.

In GitLab by @bjthehun on Nov 18, 2022, 16:14

Commented on src/print_backends/petgraph.rs line 32

Graphviz dependency noted in README.md.

In GitLab by @bjthehun on Nov 18, 2022, 16:18

Commented on src/print.rs line 3

They look awkward in VS Code, at least to me: Bildschirmfoto_vom_2022-11-18_15-55-01 I don't know why those bulletin points are added to each line. With ///-comments, it does look better to me: