Add FilterMap docs - [merged]

[slrtbtfs]

Merges docsdocsdocs -> main

fixes #34

[slrtbtfs]

requested review from @bjthehun

[slrtbtfs]

In GitLab by @bjthehun on Dec 15, 2022, 10:34

Commented on src/graph_backends/filter_map.rs line 7

implement ... to -> implement ... on

[slrtbtfs]

In GitLab by @bjthehun on Dec 15, 2022, 10:35

Commented on src/graph_backends/filter_map.rs line 12

can reference -> maintain the indices?

[slrtbtfs]

In GitLab by @bjthehun on Dec 15, 2022, 10:37

Commented on src/graph_backends/filter_map.rs line 22

must outlive -> outlives?

[slrtbtfs]

In GitLab by @bjthehun on Dec 15, 2022, 10:39

Commented on src/graph_backends/filter_map.rs line 19

Mention: general_filter_map takes both single nodes and edges, as well as the graph structure into account.

[slrtbtfs]

In GitLab by @bjthehun on Dec 15, 2022, 10:41

Commented on src/graph_backends/filter_map.rs line 56

"the this" reads strange to me Maybe: "For example, this can be used to..."

[slrtbtfs]

In GitLab by @bjthehun on Dec 15, 2022, 10:42

Commented on src/graph_backends/filter_map.rs line 127

...applying the respective transformation to each node and edge weight, without removing...

[slrtbtfs]

thanks

[slrtbtfs]

i actually meant reference here, added some hopefully clarifying language.

[slrtbtfs]

"must outlive" is meant as a requirement, clarified that.

[slrtbtfs]

good idea

[slrtbtfs]

Thanks for the review, I think the issues raised should now be addressed.

[slrtbtfs]

changed this line in version 2 of the diff

[slrtbtfs]

changed this line in version 2 of the diff

[slrtbtfs]

changed this line in version 2 of the diff

[slrtbtfs]

changed this line in version 2 of the diff

[slrtbtfs]

added 1 commit

• f129fffa - Include review suggestions

Compare with previous version

[slrtbtfs]

added 1 commit

• cccffbd4 - Include review suggestions

Compare with previous version

[slrtbtfs]

In GitLab by @bjthehun on Dec 21, 2022, 10:05

resolved all threads

[slrtbtfs]

In GitLab by @bjthehun on Dec 21, 2022, 10:05

approved this merge request

[slrtbtfs]

In GitLab by @bjthehun on Dec 21, 2022, 10:05

mentioned in commit 3c06ebe47e577dfb2e1b2603a2836b047730c927