Closed slrtbtfs closed 1 year ago
requested review from @bjthehun
In GitLab by @bjthehun on Dec 15, 2022, 10:22
Commented on src/graph_backends/filter_map.rs line 161
We could add more extensive documentation here (i.e. how to invoke this macro, its variants, internal workings, example/doc-tests...)
In GitLab by @bjthehun on Dec 15, 2022, 10:24
Commented on src/graph_backends/filter_map.rs line 170
At least on my machine & rustc 1.68; match syntax works fine:
match node {
$node_pattern => Some(node),
_ => None,
}
In GitLab by @bjthehun on Dec 15, 2022, 10:32
Commented on src/graph_backends/filter_map.rs line 160
Maybe we could move macros into their own module, i.e. query.
fixes #37
This macro is specific to filter map, so I think we can keep it there for now. That might change if we end up having more macros.
hm, now it works for me, too.
In GitLab by @bjthehun on Dec 21, 2022, 10:08
resolved all threads
In GitLab by @bjthehun on Dec 21, 2022, 10:08
approved this merge request
In GitLab by @bjthehun on Dec 21, 2022, 10:08
mentioned in commit f617cdbcf6db4139826f579262ca104e55d4ad60
Merges macros -> main
First experiments towards #37.
See the tests for how that syntax could be used.